feat(solana-wallet-snap)!: remove asset handler entry points - #261
Open
ulissesferreira wants to merge 3 commits into
Open
feat(solana-wallet-snap)!: remove asset handler entry points#261ulissesferreira wants to merge 3 commits into
ulissesferreira wants to merge 3 commits into
Conversation
ulissesferreira
force-pushed
the
WPN-2013-remove-asset-handlers
branch
2 times, most recently
from
September 3, 2026 16:39
964cca4 to
e1852c6
Compare
Remove the onAssetsLookup, onAssetsConversion, onAssetHistoricalPrice, and onAssetsMarketData entry points, along with their now-unused handler modules and the endowment:assets permission. Closes WPN-2013
Remove the code left orphaned by the asset handler removal: - AssetsService.fetchAssetsMarketData and SnapAssetsAdapter.fetchAssetsMarketData - TokenPricesService (getMultipleTokensMarketData, getMultipleTokenConversions, getHistoricalPrice) and its types/tests - PriceApiClient.getHistoricalPrices and historical price types/mocks - tokenPricesService wiring in SnapAssetsAdapter and snapContext
ulissesferreira
force-pushed
the
WPN-2013-remove-asset-handlers
branch
from
September 3, 2026 17:34
e1852c6 to
cc2c915
Compare
ulissesferreira
force-pushed
the
WPN-2013-remove-asset-handlers
branch
from
September 3, 2026 17:42
cc2c915 to
7aaeeef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes WPN-2013
Summary
onAssetsLookup,onAssetsConversion,onAssetHistoricalPrice, andonAssetsMarketDataentry points fromsolana-wallet-snapsrc/core/handlers/onAsset*endowment:assetspermission from the manifestThe
AssetsServiceandTokenPricesServiceare kept since they are used by send, subscriptions, and transaction services.Breaking change
The asset handler entry points are no longer exported by the snap.